Skip to content

Documentation for new TCP Lighting (Greenwave Reality) component #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 30, 2017
Merged

Documentation for new TCP Lighting (Greenwave Reality) component #4005

merged 9 commits into from
Dec 30, 2017

Conversation

dfiel
Copy link
Contributor

@dfiel dfiel commented Nov 18, 2017 •
edited
Loading

Description:
Documentation for the TCP Lighting component (light.tcpbulbs

Pull request in home-assistant (if applicable): home-assistant/core#11282

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Nov 19, 2017
frenck
frenck requested changes Nov 19, 2017
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfiel Thank you for submitting this PR. I've reviewed it and found some stuff I'd like to see changed. Could you please take a look at my comment? Thx!

source/_components/light.tcpbulbs.markdown Outdated

Configuration variables:

- **host** (*Required*): The IP Address for the TCP Connected Gateway.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags in order to specify configuration variables in the documentation. For more information see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Fixed.

source/_components/light.tcpbulbs.markdown Outdated
sharing: true
footer: true
ha_category: Light
ha_release: 0.XX.X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set it to 0.59 to start with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Fixed.

frenck
frenck requested changes Nov 21, 2017
View reviewed changes
source/_components/light.tcpbulbs.markdown Outdated
host: XXX.XXX.XXX.XXX
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this header as well. It will be provided by the configuration tags you've added earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Fixed!

frenck
frenck previously approved these changes Nov 21, 2017
View reviewed changes
@frenck
Copy link
Member

frenck commented Nov 21, 2017

@dfiel, thank you for making those improvements!
PR is ready to merge and can be merged as soon as the parent PR gets merged.

frenck
frenck previously approved these changes Nov 23, 2017
View reviewed changes
@dfiel
Copy link
Contributor Author

dfiel commented Dec 24, 2017

@frenck The main pull request was merged, can this be merged as well? Thanks.

@frenck frenck added this to the 0.61 milestone Dec 28, 2017
@dfiel dfiel mentioned this pull request Dec 29, 2017
Merged
6 tasks
@frenck
Copy link
Member

frenck commented Dec 30, 2017

@dfiel Thanks for the ping. Nevertheless, a second parent PR was opened?
Will these docs change? I would suggest opening a secondary PR on the documentation for that.

@frenck frenck merged commit dceec87 into home-assistant:next Dec 30, 2017
@dfiel
Copy link
Contributor Author

dfiel commented Dec 30, 2017

@frenck No documentation changes with the new PR. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfiel @frenck