Skip to content

Stop external link icons from wrapping #40219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Stop external link icons from wrapping #40219

merged 2 commits into from
Jul 30, 2025

Conversation

mrdarrengriffin
Copy link
Contributor

@mrdarrengriffin mrdarrengriffin commented Jul 30, 2025 •
edited
Loading

Proposed change

Fixes an issue where scrolling on pages (primarily blog posts) would lead to a weird snapping effect. This was due to the external link icon being unloaded/loaded upon entering/exiting the viewport.

Thanks to @teetow for helping fix this issue

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Jul 30, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 1e15638
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/688a6de9dccff4000896b8af
😎 Deploy Preview https://deploy-preview-40219--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mrdarrengriffin mrdarrengriffin marked this pull request as ready for review July 30, 2025 19:13
@joostlek joostlek merged commit d555d63 into current Jul 30, 2025
9 checks passed
@joostlek joostlek deleted the scrolling-bug-fix branch July 30, 2025 19:15
@mrdarrengriffin mrdarrengriffin mentioned this pull request Jul 30, 2025
Closed
@kroimon
Copy link
Contributor

kroimon commented Jul 30, 2025

It still wiggles for me in the deploy preview, but maybe I have to clear my cache and check on the live page later...

@mrdarrengriffin
Copy link
Contributor Author

@kroimon, if you inspect the page, click on a link that has an external URL, does it have a white-space: nowrap on it? For context, this is a fix only for blog posts for now

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll issue in release notes pages
3 participants
@mrdarrengriffin @kroimon @joostlek