-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update Ecovacs breaking change text for 2025.08 #40268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the breaking change text for the Ecovacs integration in the 2025.08 release blog post to use improved wording suggested by @MartinHjelmare in a related core pull request.
Key changes:
- Replaced generic text about battery properties removal with specific explanation about
battery_level
state attribute removal - Added context about Home Assistant's decision to remove battery state attributes from vacuum entities
- Included proper attribution and links for the additional contributor
@@ -452,12 +452,14 @@ If you have automations or scripts that rely on the Cambridge Audio media player | |||
|
|||
{% details "Ecovacs" %} | |||
|
|||
The battery properties of the legacy vacuum entity are removed and migrated into separate Battery and Charging entities. | |||
The `battery_level` state attribute of the Ecovacs vacuum entity was removed, as Home Assistant has decided to remove support for battery state attributes on vacuum entities in general. If you're using the `battery_level` state attribute in automations or scripts, please update them to use the separate Battery sensor entity instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is quite long and contains multiple ideas. Consider breaking it into shorter sentences for better readability, especially for non-native English speakers. For example: 'The battery_level
state attribute of the Ecovacs vacuum entity was removed. Home Assistant has decided to remove support for battery state attributes on vacuum entities in general. If you're using the battery_level
state attribute in automations or scripts, please update them to use the separate Battery sensor entity instead.'
Copilot generated this review using guidance from copilot-instructions.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
@MartinHjelmare suggested a better wording in home-assistant/core#149581. Use that one for the blog too
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.