Skip to content

Update Ecovacs breaking change text for 2025.08 #40268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

edenhaus
Copy link
Member

@edenhaus edenhaus commented Aug 4, 2025

Proposed change

@MartinHjelmare suggested a better wording in home-assistant/core#149581. Use that one for the blog too

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@edenhaus edenhaus added this to the 2025.8 milestone Aug 4, 2025
@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 11:50
@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Aug 4, 2025
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Aug 4, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 684d70b
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/68909e7286e4b30008cccb8a
😎 Deploy Preview https://deploy-preview-40268--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@edenhaus edenhaus removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Aug 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the breaking change text for the Ecovacs integration in the 2025.08 release blog post to use improved wording suggested by @MartinHjelmare in a related core pull request.

Key changes:

  • Replaced generic text about battery properties removal with specific explanation about battery_level state attribute removal
  • Added context about Home Assistant's decision to remove battery state attributes from vacuum entities
  • Included proper attribution and links for the additional contributor

@@ -452,12 +452,14 @@ If you have automations or scripts that rely on the Cambridge Audio media player

{% details "Ecovacs" %}

The battery properties of the legacy vacuum entity are removed and migrated into separate Battery and Charging entities.
The `battery_level` state attribute of the Ecovacs vacuum entity was removed, as Home Assistant has decided to remove support for battery state attributes on vacuum entities in general. If you're using the `battery_level` state attribute in automations or scripts, please update them to use the separate Battery sensor entity instead.
Copy link
Preview

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is quite long and contains multiple ideas. Consider breaking it into shorter sentences for better readability, especially for non-native English speakers. For example: 'The battery_level state attribute of the Ecovacs vacuum entity was removed. Home Assistant has decided to remove support for battery state attributes on vacuum entities in general. If you're using the battery_level state attribute in automations or scripts, please update them to use the separate Battery sensor entity instead.'

Copilot generated this review using guidance from copilot-instructions.md.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 0f379a5 into rc Aug 4, 2025
9 checks passed
@MartinHjelmare MartinHjelmare deleted the edenhaus-fix-ecovacs-breaking-changes branch August 4, 2025 12:03
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Aug 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
@frenck frenck removed this from the 2025.8 milestone Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in another repo rc This PR is against the RC branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants