✅ Deploy Preview for home-assistant-docs ready!

Name	Link
🔨 Latest commit	bb28a99
🔍 Latest deploy log	https://app.netlify.com/projects/home-assistant-docs/deploys/68a2ee7cdea5de0008d42846
😎 Deploy Preview	https://deploy-preview-40410--home-assistant-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Before merging, let's resolve the comments.

Current wording is ok for me. @c0ffeeca7 , do you have additional comments?

Before merging, let's resolve the comments.

Current wording is ok for me. @c0ffeeca7 , do you have additional comments?

The comment about maximal/minimal remains open.

Before merging, let's resolve the comments.

Current wording is ok for me. @c0ffeeca7 , do you have additional comments?

yes. "Maximal/minimal good". What is this? Doesn't sound like correct English. Is this what the sensor is called? What does it do?

I'm drafting this PR, as changes are needed. Please undraft it, once the changes have been implemented and the PR is ready for review again.

Before merging, let's resolve the comments.

Current wording is ok for me. @c0ffeeca7 , do you have additional comments?

yes. "Maximal/minimal good". What is this? Doesn't sound like correct English. Is this what the sensor is called? What does it do?

First off, my intent was that it is read with value, i.e. "maximal/minimal good value" and "maximal/minimal acceptable value", respectively. Agree, that this is not a very good wording (I wont comment if it is correct English and leave this for native speakers to decide), but I just had no better idea.
For the background: FYTA has several measurement sensors for plants, e.g. a temperature sensor. The thresholds now added as extra parameter represent the range where the plant feels "good" or "acceptable", respectively. So if the temperature is below the acceptable minimum, it means that it is too cold for the plant. I don't think the parameters have a huge value for the user to see, but as described in the PR can be used for automations (e.g. notifications) or the dashboard (we will use it for the fyta-plant-card).

Before merging, let's resolve the comments.

Current wording is ok for me. @c0ffeeca7 , do you have additional comments?

yes. "Maximal/minimal good". What is this? Doesn't sound like correct English. Is this what the sensor is called? What does it do?

First off, my intent was that it is read with value, i.e. "maximal/minimal good value" and "maximal/minimal acceptable value", respectively. Agree, that this is not a very good wording (I wont comment if it is correct English and leave this for native speakers to decide), but I just had no better idea. For the background: FYTA has several measurement sensors for plants, e.g. a temperature sensor. The thresholds now added as extra parameter represent the range where the plant feels "good" or "acceptable", respectively. So if the temperature is below the acceptable minimum, it means that it is too cold for the plant. I don't think the parameters have a huge value for the user to see, but as described in the PR can be used for automations (e.g. notifications) or the dashboard (we will use it for the fyta-plant-card).

Does it mean "Best/worst value for the plant"?

No, not best worst. It's a range. Let's say you have a Banana that likes it warm. So below 10 it's too cold, that could be min acceptable. 15 could be min good. Between 15 and 30 is perfect. 30 would be max good and probably 35 would be max acceptable. Above 35 it's too hot.

No, not best worst. It's a range. Let's say you have a Banana that likes it warm. So below 10 it's too cold, that could be min acceptable. 15 could be min good. Between 15 and 30 is perfect. 30 would be max good and probably 35 would be max
acceptable. Above 35 it's too hot.

Ok, so maybe something like this to give a bit more context?
For the measurement sensors (light, moisture, salinity, and temperature), the maximal/minimal values that define the ranges of what is considered acceptable and good for the plant are saved as an extra attribute of the sensor. For example: Below 10 it's too cold, that could be the minimum acceptable. 15 could be the minimum of the good range. Between 15 and 30 is perfect. 30 would be maximum good and 35 would be the maximum acceptable. Above 35 it's too hot. These values can be used for automations or visualizations on the dashboard.