Skip to content

Updated documentation about running local development instance. #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2017
Merged

Conversation

PeWu
Copy link
Contributor

@PeWu PeWu commented Dec 12, 2017

Description:
Updated documentation about running local development instance.

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck
Copy link
Member

frenck commented Dec 13, 2017

Why would you run this without venv?

@PeWu
Copy link
Contributor Author

PeWu commented Dec 13, 2017

I'm just following the instructions on this page.
The instructions say: "If you plan on providing isolation to your environment using venv..." so I skipped this part.
Everything works without venv. Why would I use venv if it works without it?

@fabaff
Copy link
Member

fabaff commented Dec 16, 2017

We should do it the other way around and suggest to use a venv.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@PeWu
Copy link
Contributor Author

PeWu commented Dec 16, 2017

Fine with me as long as the instructions are easy to follow.
@fabaff, your changes make it more clear.

@fabaff fabaff merged commit de6ecd1 into home-assistant:current Dec 16, 2017
@fabaff
Copy link
Member

fabaff commented Dec 16, 2017

@PeWu thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants