Added support for multiple onvif profiles #4445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to pull request home-assistant/core#11651
9 tasks
frenck
previously approved these changes
Jan 17, 2018
|
@karlkar Thank you for this PR! I've corrected some minors. Ready to merged as soon as the parent PR gets merged. |
Removed information about profile data in attributes, as it is not going to be implemented.
balloob
pushed a commit
that referenced
this pull request
Mar 9, 2018
* Added support for multiple onvif profiles Related to pull request home-assistant/core#11651 * ✏️ Spelling & grammar fixes * Removed info about profile data in attribute Removed information about profile data in attributes, as it is not going to be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Onvif cameras often provide more than one stream. Each stream has different video quality. Until this PR Home Assistant was always using the first (often highest quality) profile. It causes some issues on devices like RPI - stream is too heavy to be handled by ffmpeg in real time, so there are glitches and artifacts.
Pull request in home-assistant (if applicable): home-assistant/core#11651
Checklist:
current. New documentation for platforms/components and features should go tonext.