Update switch.pilight.markdown to add variables and update links #4522
Conversation
The variables unitcode and programcode are missing from the variables-list, unitcode is mentioned in the text below but they should be listed as optional variables if they are in fact optional variables. furthermore the wiki-links to pilight are outdated, so i replaced the wiki.pilight.org links with manual.pilight,org links to their respective updated pages.
| - **unit** (*Optional*): The unit to use. | ||
| - **unit** (*Optional*): The unit to use (is equivalent to pilight-send --unit). | ||
| - **unitcode** (*Optional*): The unitcode to use (is equivalent to pilight-send --unitcode). | ||
| - **programcode** (*Optional*): The programcode to use (is equivalent to pilight-send --programcode). |
There was a problem hiding this comment.
I guess this must be systemcode?
At least, there is no programcode in the source.
There was a problem hiding this comment.
there is a programcode in their documentation:
e.g. as a parameter for pilight-send: https://manual.pilight.org/programs/send.html?highlight=programcode
and as a parameter for the impuls-protocol: https://manual.pilight.org/protocols/433.92/switch/impuls.html?highlight=programcode
There was a problem hiding this comment.
Well yeah, but this is not the pilight documentation, it is Home Assistant.
I cannot find the option you are adding to the documentation, so I cannot accept/merge this PR.
Could you please update this PR with the correct parameters that match the Home Assistant code base?
delete programcode
|
Can be merged as soon as the build passes. |
Description:
The variables unitcode and programcode are missing from the variables-list, unitcode is mentioned in the text below but they should be listed as optional variables if they are in fact optional variables.
furthermore the wiki-links to pilight are outdated, so i replaced the wiki.pilight.org links with manual.pilight,org links to their respective updated pages.
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
current. New documentation for platforms/components and features should go tonext.