Add sony songpal docs #4570
Merged
Add sony songpal docs #4570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
The code part of this got just merged, so it would be nice if someone would review this, too :-) |
c727
previously approved these changes
Mar 2, 2018
c727
previously approved these changes
Mar 9, 2018
|
I don't understand why travis fails here... |
balloob
pushed a commit
that referenced
this pull request
Mar 9, 2018
* add sony songpal docs * use configuration, add a title for configuration section * remove oxford comma, add link to media_player's services * add entity_id desc for service * be more descriptive which devices are supported * Update songpal supported devices + bump version * discoverY * Update media_player.songpal.markdown * Fix invalid syntax
|
Sorry for not noticing that before, thanks balloob for the fix and c727 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add documentation for Sony Songpal platform.
Pull request in home-assistant (if applicable):
home-assistant/core#12143
Checklist:
current. New documentation for platforms/components and features should go tonext.