Skip to content

adding supported domains for Google Assistant component #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

cogneato
Copy link
Contributor

@cogneato cogneato commented Feb 7, 2018

ref: #4036

Adds supported domains and default mappings.

Description:
Not sure if this is the best position for the info, or if mappings should be included. Does anyone have an opinion?

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

ref: #4036

Adds supported domains and default mappings.
@cogneato cogneato requested a review from philk February 7, 2018 23:46
Copy link
Contributor

@philk philk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing sensor but I'm fine with that since honestly sensor requires more explanation due to the slightly janky way it had to be implemented (fake thermostat and separate temp/humidity devices).

@cogneato cogneato merged commit 512a618 into current Feb 8, 2018
@frenck frenck deleted the cogneato-patch-1 branch February 8, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants