Skip to content

Added cover group platform #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2018
Merged

Added cover group platform #4638

merged 7 commits into from
Mar 15, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 11, 2018

Description:
Added documentation for the cover group platform.

Pull request in home-assistant (if applicable): home-assistant/core#12692

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@cdce8p cdce8p changed the title New component - cover.Multicover Added cover group platform Feb 22, 2018
arsaboo
arsaboo previously approved these changes Mar 7, 2018
Copy link
Contributor

@arsaboo arsaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...can be merged when the parent PR is merged.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 13, 2018
frenck
frenck previously approved these changes Mar 13, 2018
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p Looks good! Can be merged as soon as the parent PR gets merged. 🥇

@frenck
Copy link
Member

frenck commented Mar 15, 2018

  • Rebased the PR in order to fix the build.
  • Removed incorrect CLA check.

Parent PR is merged, I'll go ahead an merge this one in.

@frenck frenck merged commit 33e7be6 into home-assistant:next Mar 15, 2018
@cdce8p
Copy link
Member Author

cdce8p commented Mar 15, 2018

Thanks @frenck 👍

@cdce8p cdce8p deleted the next-multicover branch March 15, 2018 20:58
@frenck
Copy link
Member

frenck commented Mar 15, 2018

No, no @cdce8p, thank you for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants