Skip to content

Added 1ch MiLight dimmer support. #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Added 1ch MiLight dimmer support. #4718

merged 2 commits into from
Feb 21, 2018

Conversation

rubenverhoef
Copy link
Contributor

@rubenverhoef rubenverhoef commented Feb 20, 2018

Description:
Added documentation for a 1ch MiLight dimmer.

Pull request in home-assistant (if applicable): home-assistant/core#12558

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@@ -18,7 +18,7 @@ ha_release: pre 0.7

### {% linkable_title Setup %}

Before configuring Home Assistant, make sure you can control your bulbs or LEDs with the MiLight mobile application. Discover your bridge(s) IP address. You can do this via your router or a mobile application like Fing ([android](https://play.google.com/store/apps/details?id=com.overlook.android.fing&hl=en) or [iTunes](https://itunes.apple.com/us/app/fing-network-scanner/id430921107?mt=8)). Keep in mind that LimitlessLED bulbs are controlled via groups. You can not control an individual bulb via the bridge, unless it is in a group by itself. Note that you can assign an `rgbw`, `rgbww` and `white` group to the same group number, effectively allowing 12 groups (4 `rgbww`, 4 `rgbw` and 4 `white`) per bridge.
Before configuring Home Assistant, make sure you can control your bulbs or LEDs with the MiLight mobile application. Discover your bridge(s) IP address. You can do this via your router or a mobile application like Fing ([android](https://play.google.com/store/apps/details?id=com.overlook.android.fing&hl=en) or [iTunes](https://itunes.apple.com/us/app/fing-network-scanner/id430921107?mt=8)). Keep in mind that LimitlessLED bulbs are controlled via groups. You can not control an individual bulb via the bridge, unless it is in a group by itself. Note that you can assign an `rgbw`, `rgbww`, `white` and `dimmer` group to the same group number, effectively allowing 12 groups (4 `rgbww`, 4 `rgbw`, 4 `white` and 4 `dimmer`) per bridge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must add up to 16 groups then? It's a nitpick but some user is bound to be confused by that, so please fix it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly, is it possible to have 16 groups? I think so, because the remote_style is different for this dimmer?
I just have one milight dimmer which i want to control with home-assistant. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, he means just update the part where it says "12 groups" to read "16 groups".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, :) i will do that

@@ -74,6 +77,9 @@ Refer to the [light]({{site_root}}/components/light/) documentation for general
- When using a legacy WiFi bridge (before v6), you can observe on the MiLight mobile application, you can not select a specific brightness or temperature - you can only step each property up or down. There is no indication of which step you are on. This restriction, combined with the unreliable nature of LimitlessLED transmissions, means that setting white bulb properties is done on a best-effort basis. The only very reliable settings are the minimum and maximum of each property.
- *Temperature*: Wifi bridge v6 supports 101 temperature steps; older versions only 10.
- *Brightness*: Wifi bridge v6 supports 101 brightness steps; older versions only 10.
- **Dimmer**
- This type is for a single color LED dimmer like the 1CH MiLight dimmer module or similar. Version 6 Wifi bridges are supported and not sure if legacy Wifi bridges(before v6) are working with this type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove " and not sure if legacy Wifi bridges(before v6) are working with this type" since it won't work in HA at least (no legacy command set was added).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only version 6 of the bridge is supported, and support for the older versions is dropped? Because the rest of the documentation is talking about the legacy wifi bridges... I only have an V6 bridge with one LED controller.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old bridges only support lights that existed at that time, AFAIK.

This is similar to RGBWW which has a note "(Only supported on v6 bridges)" so actually you could remove the entire last sentence and add that note in a similar way, for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly speaking, python-limitlessled and therefore HASS support legacy (v5 and earlier) and current (v6) bridges. But support for the 1CH dimmer is only available for v6 bridges (since your PR added a V6 command set, not a Legacy command set). v5 doesn't have dimmers anyway, I don't think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for the fast explanation. I will edit this tomorrow and update the PR.

Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

@amelchio amelchio merged commit b5dbc78 into home-assistant:next Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants