Skip to content

Update downloader.markdown #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2018
Merged

Update downloader.markdown #4916

merged 2 commits into from
Mar 14, 2018

Conversation

engrbm87
Copy link
Contributor

@engrbm87 engrbm87 commented Mar 14, 2018 •
edited
Loading

Description:
Add description for new events that are emitted when download is requested.

Pull request in home-assistant (if applicable): home-assistant/core#12961

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@engrbm87 engrbm87 mentioned this pull request Mar 14, 2018
Merged
9 tasks
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 14, 2018
@frenck frenck changed the base branch from current to next March 14, 2018 08:55
@frenck frenck changed the title Update downloader.markdown [WIP] Update downloader.markdown Mar 14, 2018
@frenck frenck self-assigned this Mar 14, 2018
frenck
frenck requested changes Mar 14, 2018
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased onto the next branch

@frenck frenck changed the base branch from next to current March 14, 2018 11:28
@frenck frenck changed the base branch from current to next March 14, 2018 11:28
engrbm87 and others added 2 commits March 14, 2018 13:22
@engrbm87 @frenck
Update downloader.markdown
b7f4c6c 
Add description for new events that are emitted when download is requested.
@frenck
✏️ Small fixes
316d0b9
@frenck frenck changed the title [WIP] Update downloader.markdown Update downloader.markdown Mar 14, 2018
@frenck
Copy link
Member

frenck commented Mar 14, 2018

Rebased this PR onto next

frenck
frenck approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✅. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed their assignment Mar 14, 2018
@balloob balloob merged commit 25148ef into home-assistant:next Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engrbm87 @frenck @balloob