Small comment added to expose_by_default #4936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DubhAd
previously approved these changes
Mar 16, 2018
|
Ignore me, I thought this was for emulated_hue. I'm obviously a lot more tired than I thought. Time for bed! |
It's not entirely clear that listing specific entities in entity_config is not enough to expose an entity if expose_by_default is set to false. (This is my first PR so I hope I've done it correctly)
frenck
previously approved these changes
Mar 17, 2018
|
Rebased the PR in order to fix the build issues. |
frenck
approved these changes
Mar 18, 2018
nielstron
pushed a commit
to nielstron/home-assistant.github.io
that referenced
this pull request
Mar 22, 2018
* Small comment added to expose_by_default It's not entirely clear that listing specific entities in entity_config is not enough to expose an entity if expose_by_default is set to false. (This is my first PR so I hope I've done it correctly) * ✏️ Rewording in order to fix the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear that listing specific entities in entity_config is not enough to expose an entity if expose_by_default is set to false.
(This is my first PR so I hope I've done it correctly)
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
current. New documentation for platforms/components and features should go tonext.