Add support for multiple Doorbird stations #5205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@oblogic7 Good work on this. I just closed my own PR because I forgot to check to see if someone else did it already. Please remember to conform the docs to your code so we can see this in the next release. ;) |
|
Wanted to make sure I had all of the requested changes done before updating
the docs. Gonna work on that today.
…On Tue, May 22, 2018 at 2:09 AM Alan Tse ***@***.***> wrote:
@oblogic7 <https://github.com/oblogic7> Good work on this. I just closed
my own PR because I forgot to check to see if someone else did it already.
Please remember to conform the docs to your code so we can see this in the
next release. ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5205 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbs0OOGA2GsKm09iWs4AyMtvh29pNaGks5t07mogaJpZM4TbBBb>
.
|
|
Documentation has been updated to match changes on home-assistant/core#13994 |
|
Could you recycle and update the config section of #5414. It's the preferred format for config schemas. |
syssi
previously approved these changes
May 23, 2018
|
Please update the section, too. It doesn't include the multiple device support right now. |
|
Please rebase the docs and fix the merge conflict. Does all changes still apply? |
|
Yes, it is up to date with all changes on home-assistant/core#13994 |
syssi
approved these changes
Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Edits documentation for supporting multiple devices.
Pull request in home-assistant (if applicable): home-assistant/core#13994
Checklist:
current. New documentation for platforms/components and features should go tonext.