Add Template Sensor device_class support #5220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
OttoWinter
commented
Apr 24, 2018
| @@ -47,17 +47,6 @@ sensor: | |||
| friendly_name: Pixel of Paulus | |||
| unit_of_measurement: "%" | |||
| value_template: '{{ states.device_tracker.paulus_pixel.attributes.battery|int }}' | |||
| icon_template: >- | |||
There was a problem hiding this comment.
I removed this nice template here because the device_class does the dynamic battery level icon. Still, this template is quite a nice way to learn more about the template engine, at least I myself learned a lot about how jinja2 worked using this template.
| mdi:battery-alert | ||
| {% endif %} | ||
| entity_id: | ||
| - device_tracker.paulus_pixel |
There was a problem hiding this comment.
Manual entity_id selection should no longer be necessary in most cases (including this one). So to keep the docs a bit simple, I removed it here.
balloob
approved these changes
May 1, 2018
Danielhiversen
added a commit
that referenced
this pull request
May 3, 2018
This reverts commit dcda30e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a
device_classattribute to thesensor.templateplatform. Requires #5219 for sensordevice_classdocs.Pull request in home-assistant (if applicable): home-assistant/core#14034
Checklist:
current. New documentation for platforms/components and features should go tonext.