Skip to content

Add device_descriptor and device_name to keyboard event #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Add device_descriptor and device_name to keyboard event #5443

merged 1 commit into from
Jun 8, 2018

Conversation

glenn20
Copy link
Contributor

@glenn20 glenn20 commented May 27, 2018

Document proposed feature to publish device_descriptor and device_name in keyboard_remote events.

This information can be used in automation triggers so that different bluetooth remotes can control different devices/automations.

Pending acceptance of proposed change.

Description:

Pull request in home-assistant (if applicable): home-assistant/core#14642

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Document proposed feature to publish device_descriptor and device_name in keyboard_remote events.

This information can be used in automation triggers so that different bluetooth remotes can control different devices/automations.

Pending acceptance of proposed change.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase this PR?
All kinds of commits are now coming with it...

@frenck frenck changed the title Patch 1 Add device_descriptor and device_name to keyboard event May 31, 2018
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 31, 2018
@glenn20
Copy link
Contributor Author

glenn20 commented Jun 1, 2018

Thanks - I might need some help with rebasing. I generated the pull request from the "edit on this page" link. Not sure of the workflow to rebase from there. Apologies if I generated the pull request incorrectly.

@balloob balloob changed the base branch from next to rc June 8, 2018 21:01
@balloob balloob merged commit 405ace7 into home-assistant:rc Jun 8, 2018
@glenn20 glenn20 deleted the patch-1 branch June 9, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants