Skip to content

Caseta 1804 #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Caseta 1804 #5831

merged 2 commits into from
Aug 18, 2018

Conversation

mdonoughe
Copy link
Contributor

Description:

Back in April Home Assistant was updated to use a new copy of pylutron_caseta for compatibility with a firmware update, but the documentation was not updated.

The new version of pylutron_caseta joins the names of rooms and devices together so if you have a lamp called "Bedroom Lamp" and you've put it an a room called "Bedroom" the actual device name comes out as bedroom_bedroom_lamp. I've updated the documentation to suggest you should name the lamp just "Lamp" to get bedroom_lamp. (I have a code change for entity registry support ready with the next release of pylutron_caseta should be very soon)

More importantly, the version of get_lutron_certs.py bundled with the documentation should still work but exits with an error at the end. Since April, the pylutron-caseta repo has kept an updated copy of the script in its master branch, and I've updated the documentation to point to that one.

Finally, I've also reformatted the configuration section to use {% configuration %}.

Pull request in home-assistant (if applicable): home-assistant/core#14013

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 20, 2018
@frenck frenck added ready-for-review This PR needs to be reviewed has-parent This PR has a parent PR in a other repo current This PR goes into the current branch labels Jul 21, 2018
@frenck frenck removed the to-do label Aug 6, 2018
@frenck frenck self-assigned this Aug 13, 2018
Copy link
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DubhAd DubhAd merged commit edeb14e into home-assistant:current Aug 18, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants