Skip to content

added a warning for possible memory leak #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2018

Conversation

bvansambeek
Copy link
Contributor

@bvansambeek bvansambeek commented Jul 27, 2018

as discussed here home-assistant/core#11594 (comment)

Description:
I was not able to correctly link within the text to the 2 sources as:
issue with the HBMQTT broker

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 27, 2018
@frenck frenck added enhancement ready-for-review This PR needs to be reviewed current This PR goes into the current branch and removed to-do labels Jul 29, 2018
@ghost ghost assigned frenck Jul 29, 2018
@frenck frenck merged commit 94d1ad2 into home-assistant:current Jul 29, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jul 29, 2018
<p class='note warning'>
There is an issue with the HBMQTT broker that can cause a memory leak (slowly increasing used memory). This causes an unstable system after the memory is full. You could measure/monitor this with a system monitor. The issue is from 2016 and could already be resolved with newer versions. Use another broker when you experience this issue, for example, Mosquitto. <br>
<br>
Issue with the HBMQTT broker: https://github.com/beerfactory/hbmqtt/issues/62 <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use formatting for links

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link formatting was not working at the time, see you already fixed it and made it smaller. 👍

@frenck
Copy link
Member

frenck commented Aug 13, 2018

Sorry about that @balloob, I should have spotted that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants