Skip to content

Add times to OctoPrint Sensor documentation #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2018

Conversation

sentinel-23
Copy link
Contributor

@sentinel-23 sentinel-23 commented Jul 29, 2018

Description:
Updated to reflect changes from PR 8581

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 29, 2018
@sentinel-23 sentinel-23 changed the title Updated to reflect changes from PR 8581 Add times to OctoPrint Sensor Documentation Jul 29, 2018
@sentinel-23 sentinel-23 changed the title Add times to OctoPrint Sensor Documentation Add times to OctoPrint Sensor documentation Jul 29, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration current This PR goes into the current branch has-parent This PR has a parent PR in a other repo and removed to-do labels Jul 29, 2018


<p class='note'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really stack the page with notes?

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jul 29, 2018
@frenck
Copy link
Member

frenck commented Jul 29, 2018

Thanks, @sentinel-23 for adding this, since the PR that added it, is actually pretty old. 👍

Nevertheless, I've left one little point of feedback. If you could take a look? 👍

@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jul 29, 2018
@frenck
Copy link
Member

frenck commented Jul 29, 2018

Thanks for this @sentinel-23!

bitmoji

@frenck frenck merged commit e4ed00d into home-assistant:current Jul 29, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jul 29, 2018
@sentinel-23 sentinel-23 deleted the patch-3 branch July 29, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants