Skip to content

Update panasonic_viera markdown #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2018
Merged

Update panasonic_viera markdown #6015

merged 1 commit into from
Aug 15, 2018

Conversation

dunstad
Copy link
Contributor

@dunstad dunstad commented Aug 14, 2018

This component works fine on my model, which hasn't been listed here yet. (TH-32ES500)

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 14, 2018
@frenck frenck added enhancement needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on and removed to-do labels Aug 14, 2018
@frenck
Copy link
Member

frenck commented Aug 14, 2018

Hi, @dunstad!

Thank you for this addition. Nevertheless, this PR is targeted against the wrong branch. Updates to the current release documentation must go into the current branch.

Please change the target branch and rebase if needed.

@fabaff fabaff changed the base branch from next to current August 14, 2018 14:57
@fabaff fabaff changed the base branch from current to next August 14, 2018 14:57
@dunstad
Copy link
Contributor Author

dunstad commented Aug 15, 2018

Ah, sorry about that. I'll get it on the right one in a bit here.

@dunstad dunstad changed the base branch from next to current August 15, 2018 01:21
@dunstad @frenck
Update panasonic_viera markdown
322f6cc 
This component works fine on my model, which hasn't been listed here yet. (TH-32ES500)
@frenck frenck added ready-for-review This PR needs to be reviewed current This PR goes into the current branch and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 15, 2018
@frenck
Copy link
Member

frenck commented Aug 15, 2018

Hi @dunstad,

You needed to rebase as well, which I've now done for you.

✅ Approved. Can be merged as soon as the build passes.

@frenck frenck self-assigned this Aug 15, 2018
@dunstad
Copy link
Contributor Author

dunstad commented Aug 15, 2018

Thanks for the help! I was having trouble getting the rebase done myself, so glad to have you beat me to the punch.

fabaff
fabaff approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 02a8bf9 into home-assistant:current Aug 15, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Aug 15, 2018
@frenck frenck removed the ready-for-review This PR needs to be reviewed label Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@frenck frenck

Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunstad @frenck @fabaff