Skip to content

Add default_zoom to map card docs. #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2018
Merged

Add default_zoom to map card docs. #6113

merged 1 commit into from
Aug 31, 2018

Conversation

jeradM
Copy link
Member

@jeradM jeradM commented Aug 30, 2018

Description:
Adds default_zoom option to map card documentation.

From frontend PR: home-assistant/frontend#1592

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost assigned jeradM Aug 30, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Aug 30, 2018
@fabaff fabaff changed the base branch from current to next August 30, 2018 08:03
@ludeeus
Copy link
Member

ludeeus commented Aug 30, 2018

@jeradM Are there any limits to what number can be put it? or is any number valid?

@fabaff fabaff changed the base branch from next to rc August 30, 2018 08:03
@fabaff fabaff changed the base branch from rc to current August 30, 2018 08:03
@jeradM
Copy link
Member Author

jeradM commented Aug 30, 2018

The leaflet map api will accept any value here, but it applies limits automatically based on the current visible layers.

fabaff
fabaff approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4fafc66 into home-assistant:current Aug 31, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@jeradM jeradM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeradM @ludeeus @fabaff