Update Documentation for 'Hyperion' Light Component Configuration #6441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Oct 2, 2018
| effect_list: | ||
| description: The list of effects that can be used. | ||
| required: false | ||
| type: string |
There was a problem hiding this comment.
This is not a string, but a list.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/light/hyperion.py#L56
| default_color: | ||
| description: The color of the light. | ||
| required: false | ||
| type: string |
There was a problem hiding this comment.
This is not a string, but a list.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/light/hyperion.py#L49
|
I've reviewed this PR, and it seems to have 2 incorrect configuration variable types. Could you please take a look? |
frenck
approved these changes
Oct 3, 2018
|
Corrected the PR. Thanks for the PR @pattyland! 👍 Happy Hacktoberfest 🎉 ../Frenck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related #6385.
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.