Skip to content

Update simplisafe configuration to new format #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pdong
Copy link
Contributor

@pdong pdong commented Oct 2, 2018

Description:
This updates the simplisafe component configuration to the new format as per #6385

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost added the to-do label Oct 2, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch enhancement and removed to-do labels Oct 2, 2018
@frenck frenck changed the base branch from next to current October 2, 2018 18:09
@frenck frenck changed the base branch from current to next October 2, 2018 18:09
@frenck
Copy link
Member

frenck commented Oct 2, 2018

Hi there @pdong!

Thank you for this PR and welcome to Hacktoberfest! 🎉

Nevertheless, the PR is targeted against the wrong branch. Documentation updates on current online documentation need to go into the current branch.

In order to fix this, you'll need to rebase the PR and change the target branch from next -> current. Is rebasing something you are familiar with or need help with?

Please make the change or let me know if you need assistance.

@pdong pdong force-pushed the simplisafe-configuration-update branch from bfb21fa to fff757e Compare October 2, 2018 18:58
@pdong pdong changed the base branch from next to current October 2, 2018 18:58
@pdong
Copy link
Contributor Author

pdong commented Oct 2, 2018

@frenck Thanks. I've updated the branch to work off of current and updated the base branch. 👍

@frenck frenck unassigned pdong Oct 2, 2018
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Oct 2, 2018
frenck
frenck previously approved these changes Oct 2, 2018
@frenck frenck added current This PR goes into the current branch and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 2, 2018
@frenck
Copy link
Member

frenck commented Oct 2, 2018

Thanks for the quick update @pdong! 🥇

Feel free to open more PR (if you are up to it)! Well done.

✅ Approved.

../Frenck

@frenck frenck merged commit a510ff2 into home-assistant:current Oct 2, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants