Add warning to the MPC-HC media_player component documentation. #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it prudent to add a warning to the new MPC-HC media player component, telling users to be cautious about exposing the web UI to actors outside of their trusted network (it allows for arbitrary filesystem browsing and media player control without authentication).
I've also added a link to a simple proxy script I wrote last night that can act as a bridge between MPC-HC running with the web UI restricted to
localhostand a remote client, redacting and restricting the command set to a sane subset. I'm using this to allow HA to observe and have only basic control over my main PC's MPC-HC, while redacting the current playing information.