Skip to content

Update lovelace ID status + include and secret support #7395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2018

Conversation

bramkragten
Copy link
Member

Description:
Reverts the automatic ID adding of Lovelace and adds documentation for the support of !include and !secret.

Pull request in home-assistant (if applicable): home-assistant/core#17958

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Nov 6, 2018
@bramkragten
Copy link
Member Author

Uuuuh... that was not the intention... Now it added al changes from current to next or something?

@frenck frenck changed the base branch from next to current November 11, 2018 11:33
@frenck frenck added enhancement ready-for-review This PR needs to be reviewed current This PR goes into the current branch and removed to-do labels Nov 11, 2018
@frenck frenck added has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already and removed enhancement labels Dec 5, 2018
@ghost ghost assigned frenck Dec 5, 2018
@frenck
Copy link
Member

frenck commented Dec 5, 2018

@bramkragten Since this PR has been here for a while, it is OK now 😉
✅ Approved, fixed merge conflict, ready to merge when build passes.

@frenck frenck merged commit 278f646 into home-assistant:current Dec 5, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants