Skip to content

Add press hold for send command #7985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Add press hold for send command #7985

merged 3 commits into from
Mar 11, 2019

Conversation

ehendrix23
Copy link
Contributor

Description:

Documentation with example for the new hold_secs parameter within the send_command.

Pull request in home-assistant (if applicable): home-assistant/core#19650

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Dec 29, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Dec 30, 2018
DubhAd
DubhAd previously requested changes Feb 2, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 4, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehendrix23 There are some review changes requested and there appears to be a merge conflict. Could you please take a look? 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Mar 6, 2019
@ehendrix23
Copy link
Contributor Author

Updates done :-)

@frenck
Copy link
Member

frenck commented Mar 11, 2019

Thanks, @ehendrix23 👍

@frenck frenck dismissed DubhAd’s stale review March 11, 2019 18:52

Comments addressed.

@frenck frenck merged commit 81cd16d into home-assistant:next Mar 11, 2019
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants