Skip to content

Google pubsub #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 11, 2019
Merged

Google pubsub #8153

merged 11 commits into from
Feb 11, 2019

Conversation

timvancann
Copy link
Contributor

@timvancann timvancann commented Jan 13, 2019 •
edited
Loading

Description:

Guide for the Home Assistant Google Pub/Sub component.

Pull request in home-assistant (if applicable): home-assistant/core#20049

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Jan 13, 2019
@timvancann timvancann mentioned this pull request Jan 13, 2019
Merged
9 tasks
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Jan 21, 2019
@ghost ghost assigned frenck Jan 21, 2019
frenck
frenck requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timvancann Thanks for the PR! Left you one comment, could you please take a look? 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Jan 21, 2019
@frenck frenck assigned timvancann and unassigned frenck Jan 21, 2019
@frenck frenck self-assigned this Jan 22, 2019
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jan 22, 2019
frenck
frenck previously approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @timvancann! 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Jan 22, 2019
@timvancann
Copy link
Contributor Author

@frenck Version has been bumped to 0.88. Still waiting for approval of home-assistant/core#20049.

@klaasnicolaas klaasnicolaas added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Feb 11, 2019
klaasnicolaas
klaasnicolaas requested changes Feb 11, 2019
View reviewed changes
@ghost ghost added the to-do label Feb 11, 2019
@frenck frenck merged commit ae4facc into home-assistant:next Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaasnicolaas klaasnicolaas klaasnicolaas approved these changes

@frenck frenck frenck left review comments

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvancann @frenck @klaasnicolaas