Create sensor.tof #8672
Merged
Create sensor.tof #8672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaasnicolaas
requested changes
Feb 21, 2019
Co-Authored-By: josemotta <josemotta@bampli.com>
klaasnicolaas
previously requested changes
Feb 22, 2019
Co-Authored-By: josemotta <josemotta@bampli.com>
|
Having some issues also at pull request at home assistant. Any help? Pull request in home-assistant: home-assistant/home-assistant#21230 |
|
Why closing this PR? |
|
Sorry, wrong action. Please keep it! It´s my first time here I was trying to ask for help at code PR; Thanks for your support |
|
reopening |
9 tasks
|
There is a broken link at top right: Source: tof/sensor.py Actually it should be https://deploy-preview-8672--home-assistant-docs.netlify.com/components/sensor.tof/ |
|
This is known and has to do with "The Great Migration". The documentation code currently only looks at the "new" situation. From the documentation perspective, there is currently nothing you can do about that. |
MartinHjelmare
requested changes
Mar 8, 2019
MartinHjelmare
previously approved these changes
Mar 8, 2019
frenck
previously approved these changes
Mar 11, 2019
Signed-off-by: Franck Nijhof <frenck@addons.community>
frenck
approved these changes
Mar 11, 2019
|
Thanks, @josemotta! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant: home-assistant/core#21230
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.