Skip to content

Expand Google pub/sub topic config description #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

simonlbn
Copy link
Contributor

@simonlbn simonlbn commented Mar 2, 2019

Description:
Make it more clear that the user should use the short relative pubsub name like "mytopic" and
not the longer like "projects/myproject/topics/mytopic".

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

Make it more clear that the user should use the short relative pubsub name like "mytopic" and
not the longer like "projects/myproject/topics/mytopic".
@ghost ghost added the to-do label Mar 2, 2019
@klaasnicolaas klaasnicolaas added enhancement ready-for-review This PR needs to be reviewed current This PR goes into the current branch and removed to-do labels Mar 2, 2019
@frenck
Copy link
Member

frenck commented Mar 4, 2019

Thanks, @simonlbn! 👍

@frenck frenck merged commit 552e6ab into home-assistant:current Mar 4, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants