Skip to content

Updating rotted URL for certbot guide #8800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

mikeodr
Copy link
Contributor

@mikeodr mikeodr commented Mar 2, 2019

Description:

HAProxy docs has a rotted URL to digital ocean guide
for certbot Let's Encrypt certificates.

Updated this URL to the newest guide.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Mar 2, 2019
@klaasnicolaas klaasnicolaas added needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed to-do labels Mar 2, 2019
@klaasnicolaas
Copy link
Member

I think this is something for the current branch

frenck
frenck previously approved these changes Mar 4, 2019
@frenck frenck changed the base branch from next to current March 4, 2019 11:00
HAProxy docs has a rotted URL to digital ocean guide
for certbot Let's Encrypt certificates.

Updated this URL to the newest guide.
@frenck frenck force-pushed the haproxy-stale-url branch from 0c0bdf7 to 428460e Compare March 4, 2019 11:15
@ghost ghost assigned frenck Mar 4, 2019
@ghost ghost added the ready-for-review This PR needs to be reviewed label Mar 4, 2019
@frenck frenck added enhancement current This PR goes into the current branch and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 4, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased PR onto the current branch

@frenck frenck merged commit b968470 into home-assistant:current Mar 4, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants