Skip to content

Add SmartThings climate support for Air Conditioners #8878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2019
Merged

Add SmartThings climate support for Air Conditioners #8878

merged 2 commits into from
Mar 11, 2019

Conversation

andrewsayre
Copy link
Member

@andrewsayre andrewsayre commented Mar 9, 2019 •
edited
Loading

Description:
Adds docs for Air Conditioners to the SmartThings climate platform.

Pull request in home-assistant: home-assistant/core#21840

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost assigned andrewsayre Mar 9, 2019
@ghost ghost added the ready-for-review This PR needs to be reviewed label Mar 9, 2019
@andrewsayre andrewsayre changed the title Add SmartThings climate support for Samsung Air Conditioners Add SmartThings climate support for Air Conditioners Mar 9, 2019
@andrewsayre andrewsayre mentioned this pull request Mar 9, 2019
Merged
8 tasks
@andrewsayre andrewsayre added awaits-parent Awaits the merge of an parent PR next This PR goes into the next branch has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 9, 2019
@frenck frenck self-assigned this Mar 11, 2019
frenck
frenck requested changes Mar 11, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsayre Somehow, our Jekyll doesn't like this at all!

image

@andrewsayre
Copy link
Member Author

@frenck Fixed! Just missed the line break before the table.

frenck
frenck approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andrewsayre! 👍

@frenck frenck merged commit 1b071fe into home-assistant:next Mar 11, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 11, 2019
@andrewsayre andrewsayre deleted the feature-smartthings-airconditioner branch March 27, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees

@frenck frenck

@andrewsayre andrewsayre

Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsayre @frenck