Skip to content

Adding some missing config options for Enigma2 media_player. #8911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

fbradyirl
Copy link
Contributor

@fbradyirl fbradyirl commented Mar 11, 2019

Description:
Adding documentation for existing config options for Enigma2 media_player (which I forgot about in the initial docs commit).

Here is a screenshot of the menu item mentioned in the docs (accessed on the E2 box itself via the remote control).
1_0_19_835_3EA_2174_EEEE0000_0_0_0_20190311101933

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the [standards][standards].

@ghost ghost added the to-do label Mar 11, 2019
@fbradyirl
Copy link
Contributor Author

cc: @rytilahti

@klaasnicolaas
Copy link
Member

are these config options new to HA or are they already exist in the component but not yet documented?

@fbradyirl
Copy link
Contributor Author

are these config options new to HA or are they already exist in the component but not yet documented?

These are already in the component, but I forgot to document these in the initial commit.
See https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/enigma2/media_player.py#L41

@klaasnicolaas klaasnicolaas added new-integration This PR adds documentation for a new Home Assistant integration new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Mar 11, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 11, 2019
@frenck
Copy link
Member

frenck commented Mar 11, 2019

Thanks, @fbradyirl! 👍

@frenck frenck merged commit 5a6039f into home-assistant:next Mar 11, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants