Create Component page for mysensors based HVAC #943
Conversation
| logo: mysensors.png | ||
| ha_category: Climate | ||
| featured: false | ||
| ha_release: 0.28+ |
There was a problem hiding this comment.
There is no + when I edit the file!
| #include <MySensor.h> | ||
| ... | ||
| ... | ||
| ... |
There was a problem hiding this comment.
I am just including a sample code require only for HVAC mysensors... hence put ... to signify add other necessary code. Will edit to put a comment there in the code.
| logo: mysensors.png | ||
| ha_category: Climate | ||
| featured: false | ||
| ha_release: 0.28+ |
There was a problem hiding this comment.
There is no + when I edit the file!
| #include <MySensor.h> | ||
| ... | ||
| ... | ||
| ... |
There was a problem hiding this comment.
I am just including a sample code require only for HVAC mysensors... hence put ... to signify add other necessary code. Will edit to put a comment there in the code.
|
|
||
| S_TYPE | V_TYPE | ||
| ------------|------------- | ||
| S_HVAC | [V_HVAC_SETPOINT_HEAT, V_HVAC_SETPOINT_COOL, V_HVAC_FLOW_STATE, V_HVAC_SPEED] |
There was a problem hiding this comment.
Maybe we should note that V_HVAC_FLOW_STATE is required to add the device in home assistant?
There was a problem hiding this comment.
Right... How does this look now?
There was a problem hiding this comment.
I think you can remove the brackets. Previously I've only used brackets to signify options for the same function. That's partly the case here as well, but also not entirely. I've denoted required value with a star on the other platform pages. Add a star after V_HVAC_FLOW_STATE and an explanation what the star means. Looks good otherwise.
|
Looks good! |
No description provided.