Skip to content

Edit mqtt.markdown and clarify 'certificate' option #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

chennin
Copy link
Contributor

@chennin chennin commented Sep 19, 2016

Edit mqtt topic for spelling/grammar/typos/clarity.

Importantly, clarify what certificate is used for. The current description implies it's used for encrypting communication, but that's what client_key and client_cert are for. certificate is which root certificate(s) to trust.

Edit mqtt topic for spelling/grammar/typos/clarity.

Importantly, clarify what `certificate` is used for.  The current description implies it's used for encrypting communication, but that's what `client_key` and `client_cert` are for.  `certificate` is which root certificate(s) to trust.
Copy link
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup and clarification!
Thank you.

@Landrash Landrash changed the base branch from next to current September 19, 2016 16:10
@Landrash Landrash changed the base branch from current to next September 19, 2016 16:10
@Landrash Landrash merged commit 292c4a3 into home-assistant:next Sep 19, 2016
@chennin chennin deleted the patch-1 branch September 19, 2016 17:04
@chennin chennin mentioned this pull request Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants