Update http documentation from approved_ips to trusted_networks #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
related PR has not been merged yet. |
Landrash
reviewed
Oct 6, 2016
| @@ -32,7 +32,7 @@ Configuration variables: | |||
| - **ssl_certificate** (*Optional*): Path to your TLS/SSL certificate to serve Home Assistant over a secure connection. | |||
| - **ssl_key** (*Optional*): Path to your TLS/SSL key to serve Home Assistant over a secure connection. | |||
| - **cors_allowed_origins** (*Optional*): A list of origin domain names to allow [CORS](https://en.wikipedia.org/wiki/Cross-origin_resource_sharing) requests from. Enabling this will set the `Access-Control-Allow-Origin` header to the Origin header if it is found in the list, and the `Access-Control-Allow-Headers` header to `Origin, Accept, X-Requested-With, Content-type, X-HA-access`. You must provide the exact Origin, i.e. `https://home-assistant.io` will allow requests from `https://home-assistant.io` but __not__ `http://home-assistant.io`. | |||
| - **approved_ips** (*Optional*): A list of approved ips. Then it will be possible to login from given ips without providing a password. | |||
| - **trusted_networks** (*Optional*): List of trusted networks, consisting of IP addresses or networks, that are allowed to bypass password protection when accessing Home Assistant. | |||
There was a problem hiding this comment.
Could this also be host names or only specified IP addresses?
If so it should probably be change to
trusted_networks (Optional): List of trusted networks, consisting of IP addresses, host names or networks, that are allowed to bypass password protection when accessing Home Assistant.
There was a problem hiding this comment.
No, a hostname is not a valid input for ipaddress.ip_network, only IPv4/IPv6 adresses or networks are possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to home-assistant/core#3532