Skip to content

add constants for SecuritySystemAlarmType #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

add constants for SecuritySystemAlarmType #1086

merged 1 commit into from
Mar 22, 2025

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Mar 22, 2025

I'm assuming that 0 and 1 correspond to these:

public static readonly NO_ALARM = 0;
public static readonly UNKNOWN = 1;

@bwp91 bwp91 requested a review from ebaauw March 22, 2025 12:42
Copy link
Contributor

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they do. Thanks!

I'm afraid I fail to understand how the dashes and dots in the generator configuration translate to the camelcase characteristic name and uppercase value constants, but good to see how it's done.

@bwp91 bwp91 merged commit 4d37fb1 into latest Mar 22, 2025
14 checks passed
@bwp91 bwp91 deleted the bp/alarm-types branch March 22, 2025 14:49
bwp91 added a commit that referenced this pull request Jun 1, 2025
bwp91 added a commit that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants