chore: update dependencies #3436
Conversation
Pull Request Test Coverage Report for Build 6228060496
💛 - Coveralls |
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "homebridge": "bin/homebridge" | |||
| }, | |||
| "engines": { | |||
| "node": ">=10.17.0" | |||
| "node": "^16.20.2 || ^18.17.1" | |||
There was a problem hiding this comment.
The synology package is using a slightly older Node 18 package nodejs.org 18.15.0-1008
So minimum version needs to take this into account
There was a problem hiding this comment.
Hi @NorthernMan54 I set minimum engine node version to 18.15.0.
I would preferably like to push this into a beta branch of homebridge rather than master, but not totally sure how it works on this repo
|
The node engine part was an extra I did, not sure if was really necessary or not. Have updated the downgrade of 18. But I also want to make it clear that these are the versions of node that homebridge supports, not necessarily the versions of node that homebridge will work with |
|
@donavanbecker which is latest beta branch? |
|
would think beta-1.6.1 |
The base branch was changed.
Assuming, we are fine with a minor bump, I just created a 1.7.0 beta right now. |
|
Thanks @Supereg, @bwp91 looks like we can get rid of all of the other beta branches also |
|
@bwp91, I think we are good to go on this. Unless there is something else you want to add. new beta was published for this: |
♻️ Current situation
coveragedirectoryI would like to start looking into updating some dependencies into their major new versions but wanted to get this done as the first stepping stone.
💡 Proposed solution
dependenciesto latest minor/patch versionsdevDependensiesto some latest major/minor/patch versionspackage-lock.jsoncoveragein gitignore file^16.20.2 || ^18.17.1⚙️ Release Notes
Testing
no tests changes, but all are passing
Reviewer Nudging
🤷♂️