[DRAFT] Implementation of runtime checks for deprecated elements with v2 #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the idea of this...would you be willing to take on a bit further evolution of it potentially. Essentially, many of the "fixes" (though certainly not all) are relatively trivial to make. Perhaps:
TL;DR: would be nice to self-heal/upgrade-in-place nonconforming plugins where possible. There will be instances where this can't be done, but it's a perennial 80/20 problem. One of the assets Homebridge has is it's vast library of plugins...we'd love to find a way to bring them into the future without being overly encumbered by legacy code where we can be. Welcome perspectives... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
With the upcoming breaking changes in v2 it's crucial to inform users that some of their used plugins may not work after performing the upgrade. The upgrade work relies on the plugin developers to update their plugins, which may - or may not - happen.
💡 Proposed solution
To support the users of homebridge runtime checks should be implemented to direct them at what/where things can break in case they would upgrade
⚙️ Release Notes
To be added if we're aligned on this as a viable solution.
➕ Additional Information
This implementation has the caveat that it purely (has to) rely on runtime invocation.
Example:
Characteristic.Unitsduring creation - this will cause the warning to log. If it's loaded from cache the warning won't be logged as it's already defined.Testing
To be added if we're aligned on this as a viable solution.
Reviewer Nudging
To be added if we're aligned on this as a viable solution.