support plugins with dots in their @scope #3687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10655096974Details
💛 - Coveralls |
bwp91
reviewed
Sep 1, 2024
bwp91
approved these changes
Sep 1, 2024
|
@gtalusan i have pushed your changes to both the alpha and beta versions of homebridge and the UI. maybe you have these running and could update and test that you can install your plugin correctly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
I'm writing a plugin and my npm @scope has a '.' in it. Homebridge won't load it.
💡 Proposed solution
Changing PLUGIN_IDENTIFIER_PATTERN to include a period in the regex.
⚙️ Release Notes
Support plugins with dots in their @scope
➕ Additional Information
N/A
Testing
Add corresponding tests to pluginManager.spec.ts.
Reviewer Nudging