Skip to content

Select which components to check for updates #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justjam2013
Copy link
Contributor

♻️ Current situation

Currently the plugin reports updates for Homebridge, Homebridge UI, and plugins. It's an all or nothing proposition.

💡 Proposed solution

Allow to users to independently select which components to check for updates.

➕ Additional Information

This PR provides a suggested update for feature request Ability to choose the available updates

@Sunoo
Copy link
Collaborator

Sunoo commented Jun 21, 2025

Is this a Work in Progress? I see stuff added to handle the configuration, but nothing to actually act on any of the new settings.

@justjam2013
Copy link
Contributor Author

Oh crap, part of the changes didn't get checked in! Let me see where I messed up and I'll update the PR.

@Sunoo
Copy link
Collaborator

Sunoo commented Jun 21, 2025

That'd do it! Let me know when everything is all set. This definitely seems like a change worth merging in once it's ready.

@justjam2013
Copy link
Contributor Author

Done.

@Sunoo
Copy link
Collaborator

Sunoo commented Jun 21, 2025

Great, I'll try to do a more thorough review of the code shortly.

@donavanbecker donavanbecker changed the base branch from latest to beta-2.1.0 June 27, 2025 04:46
@donavanbecker
Copy link
Contributor

I will merge this into a beta branch.

@donavanbecker
Copy link
Contributor

@justjam2013 Can you resolve the build?

@justjam2013
Copy link
Contributor Author

justjam2013 commented Jun 28, 2025

The Node Build is failing on the install step. It is dependent on the homebridge/node-pty-prebuilt-multiarch repo which is failing while trying to prebuild binaries.

I am guessing that node-pty-prebuilt-multiarch is a dependency for other plugins (and Homebridge), so I'm not the best person to be messing around under the hood without any idea of what I'm doing.

@NorthernMan54 can you take a look at this please?

@justjam2013
Copy link
Contributor Author

justjam2013 commented Jun 28, 2025

As for why the Labeler is failing, the script .github/workflows/labeler.yml is dependent on homebridge/.github/.github/workflows/labeler.yml which looks to be wrong:

Screenshot 2025-06-28 at 10 04 18 AM

The correct path appears to be homebridge/.github/.github/labeler.yml

Screenshot 2025-06-28 at 9 57 17 AM

@NorthernMan54
Copy link

@justjam2013 Node Build is failing for NodeJS 24, due to homebridge-config-ui-x not being updated to the version that supports NodeJS 24.

@justjam2013
Copy link
Contributor Author

@NorthernMan54 so does homebridge-config-ui-x need to be updated for this build to succeed?

@NorthernMan54
Copy link

You have a choice, drop NodeJS 24 from the build or update to the 5.x homebridge-config-ui-x stream

@justjam2013
Copy link
Contributor Author

You have a choice, drop NodeJS 24 from the build or update to the 5.x homebridge-config-ui-x stream

@donavanbecker @Sunoo can you fix the build process for this plugin? Then my PR will pass.

@Sunoo
Copy link
Collaborator

Sunoo commented Jun 28, 2025

I’m on a trip, but I can take a look at it when I get back in a few days if nobody beats me to it.

@justjam2013
Copy link
Contributor Author

justjam2013 commented Jun 28, 2025

If this plugin is creating prebuilds due to its dev dependency on homebridge and homebridge-config-ui-x, can these dev dependencies be removed by coding against an interface and then conditionally import homebridge and homebridge-config-ui-x or a mock?

TypeScript - conditional module import/export

Edit: I actually don't understand why this plugin is doing prebuilds 🤷‍♂️

@justjam2013
Copy link
Contributor Author

Just checking for any updates on fixing the build issue.

@Sunoo
Copy link
Collaborator

Sunoo commented Jul 14, 2025

Completely slipped my mind when I got back, will try to take a look in the next few days.

@justjam2013
Copy link
Contributor Author

Following up on this issue.

As Homebridge in Docker now provides the ability show if a new Docker image is available, rather than Homebridge or Homebridge UI versions, I would like to be able to turn off checking for the individual versions. I only update my "prod" deployment when a new Docker image is available.

This is my "prod" deployment in a Docker container:

Screenshot 2025-07-17 at 2 51 14 PM

So I would like to next submit a PR adding the Docker image as an option to check for. However it is a bit silly to do so until the plugin build issues are resolved.

@donavanbecker donavanbecker merged commit dcdb1ce into homebridge-plugins:beta-2.1.0 Jul 17, 2025
5 of 6 checks passed
@donavanbecker
Copy link
Contributor

@justjam2013 This is in the latest beta

@justjam2013 justjam2013 deleted the ability-to-choose-update-checks branch July 18, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants