-
-
Notifications
You must be signed in to change notification settings - Fork 1
Select which components to check for updates #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select which components to check for updates #59
Conversation
Is this a Work in Progress? I see stuff added to handle the configuration, but nothing to actually act on any of the new settings. |
Oh crap, part of the changes didn't get checked in! Let me see where I messed up and I'll update the PR. |
That'd do it! Let me know when everything is all set. This definitely seems like a change worth merging in once it's ready. |
Done. |
Great, I'll try to do a more thorough review of the code shortly. |
I will merge this into a beta branch. |
@justjam2013 Can you resolve the build? |
The Node Build is failing on the I am guessing that @NorthernMan54 can you take a look at this please? |
@justjam2013 Node Build is failing for NodeJS 24, due to homebridge-config-ui-x not being updated to the version that supports NodeJS 24. |
@NorthernMan54 so does homebridge-config-ui-x need to be updated for this build to succeed? |
You have a choice, drop NodeJS 24 from the build or update to the 5.x homebridge-config-ui-x stream |
@donavanbecker @Sunoo can you fix the build process for this plugin? Then my PR will pass. |
I’m on a trip, but I can take a look at it when I get back in a few days if nobody beats me to it. |
If this plugin is creating prebuilds due to its dev dependency on TypeScript - conditional module import/export Edit: I actually don't understand why this plugin is doing prebuilds 🤷♂️ |
Just checking for any updates on fixing the build issue. |
Completely slipped my mind when I got back, will try to take a look in the next few days. |
Following up on this issue. As Homebridge in Docker now provides the ability show if a new Docker image is available, rather than Homebridge or Homebridge UI versions, I would like to be able to turn off checking for the individual versions. I only update my "prod" deployment when a new Docker image is available. This is my "prod" deployment in a Docker container: So I would like to next submit a PR adding the Docker image as an option to check for. However it is a bit silly to do so until the plugin build issues are resolved. |
dcdb1ce
into
homebridge-plugins:beta-2.1.0
@justjam2013 This is in the latest beta |
♻️ Current situation
Currently the plugin reports updates for Homebridge, Homebridge UI, and plugins. It's an all or nothing proposition.
💡 Proposed solution
Allow to users to independently select which components to check for updates.
➕ Additional Information
This PR provides a suggested update for feature request Ability to choose the available updates