Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (c0d782c) to head (4389bd1).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #3474   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         155      155           
  Lines        9357     9357           
  Branches     2735     2752   +17     
=======================================
  Hits         8944     8944           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi @codehz

Thank you for the PR.

I just wanted to confirm it with you. Currently, it does not throw a type error on my machine. Is this what you're pointing out?

Hi @codehz

Thank you for the PR.

I just wanted to confirm it with you. Currently, it does not throw a type error on my machine. Is this what you're pointing out?

while in my machine

and the Window is defined as

function Window({
  id,
  title,
  state,
  zIndex,
}: {
  id: WindowId;
  title: WindowTitleState;
  state: WindowState;
  zIndex: number;
}) {...
}

@yusukebe post in typescript playground

Playground Link

Thanks @codehz !

Indeed, if we treat hono/jsx as the same as React, we should add the key attribute.

Initially, hono/jsx was developed as non-React JSX, which does not support key. If we follow that policy, we can't accept this PR. However, currently, we are saying "hono/jsx has (almost) compatibility for React." So, it may be okay to add the key attribute.

@usualoma, what do you think of this?

Hi @codehz. Thank you!

@yusukebe Compatibility with React is important now, and this addition does not affect the function for stringification, so I agree with the merge!

@usualoma Thank you for the comment.

@codehz Looks good. I'll merge this now. Thank you.