perf(context): improve performance of context (setHeaders) #3592

EdamAme-x · 2024-10-31T02:16:59Z

Improved performance of setHeaders and removed unnecessary checks in .newResponse.

The benchmark results are as follows

In Node (1.5x~ faster)

cpu: AMD EPYC 7763 64-Core Processor
runtime: node v20.18.0 (x64-linux)

benchmark             time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------------- -----------------------------
using .entries      1.19 µs/iter     (1.07 µs … 1.63 ms)   1.12 µs   2.69 µs   2.89 µs
using for syntax   707.2 ns/iter (683.65 ns … 948.47 ns) 714.47 ns 948.47 ns 948.47 ns

In Deno (4x~ faster)

cpu: AMD EPYC 7763 64-Core Processor
runtime: deno 2.0.4 (x86_64-unknown-linux-gnu)

benchmark             time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------------- -----------------------------
using .entries      3.83 µs/iter     (2.44 µs … 2.88 ms)   3.48 µs   7.12 µs   7.65 µs
using for syntax   893.5 ns/iter   (836.79 ns … 1.32 µs) 881.82 ns   1.32 µs   1.32 µs

In Bun (1.5x~ faster)

cpu: AMD EPYC 7763 64-Core Processor
runtime: bun 1.1.33 (x64-linux)

benchmark             time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------------- -----------------------------
using .entries    771.93 ns/iter   (704.77 ns … 1.25 µs) 788.32 ns   1.25 µs   1.25 µs
using for syntax   533.1 ns/iter   (440.84 ns … 1.89 µs) 522.99 ns 945.47 ns   1.89 µs

The author should do the following, if applicable

Add tests
Run tests
bun run format:fix && bun run lint:fix to format the code
Add TSDoc/JSDoc to document the code

codecov · 2024-10-31T02:20:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (caeecf9) to head (67b2b59).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         158      158              
  Lines        9557     9555       -2     
  Branches     2826     2924      +98     
==========================================
- Hits         9052     9050       -2     
  Misses        505      505

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EdamAme-x · 2024-10-31T02:22:44Z

Benchmark Source

import { run, bench } from 'mitata'

const subHeaders = {
  a: '1',
  b: '2',
  c: '3',
  d: '4',
  e: '5',
  f: '6',
}

bench('using .entries', () => {
  const headers = new Headers()

  Object.entries(subHeaders).forEach(([key, value]) => headers.set(key, value))
})

bench('using for syntax', () => {
  const headers = new Headers()

  for (let i = 0, keys = Object.keys(subHeaders), len = keys.length; i < len; i++) {
    const key = keys[i]
    headers.set(key, subHeaders[key])
  }
})

await run()

src/context.ts

yusukebe · 2024-10-31T06:55:23Z

@EdamAme-x

Thanks!

* perf(context): improve performance of context (newResponse, setHeaders) * Revert context.ts

perf(context): improve performance of context (newResponse, setHeaders)

bab654c

yusukebe reviewed Oct 31, 2024

View reviewed changes

src/context.ts Outdated Show resolved Hide resolved

Revert context.ts

67b2b59

yusukebe changed the title ~~perf(context): improve performance of context (newResponse, setHeaders)~~ perf(context): improve performance of context (setHeaders) Oct 31, 2024

yusukebe merged commit 4dd8b2b into honojs:main Oct 31, 2024
16 checks passed

usualoma mentioned this pull request Oct 31, 2024

refactor(context): use simple for-of syntax #3598

Merged

2 tasks

TinsFox pushed a commit to TinsFox/hono that referenced this pull request Nov 11, 2024

perf(context): improve performance of context (setHeaders) (honojs#3592)

161375c

* perf(context): improve performance of context (newResponse, setHeaders) * Revert context.ts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(context): improve performance of context (setHeaders) #3592

perf(context): improve performance of context (setHeaders) #3592

EdamAme-x commented Oct 31, 2024 •

edited

Loading

codecov bot commented Oct 31, 2024 •

edited

Loading

EdamAme-x commented Oct 31, 2024

yusukebe commented Oct 31, 2024

perf(context): improve performance of context (setHeaders) #3592

perf(context): improve performance of context (setHeaders) #3592

Conversation

EdamAme-x commented Oct 31, 2024 • edited Loading

In Node (1.5x~ faster)

In Deno (4x~ faster)

In Bun (1.5x~ faster)

The author should do the following, if applicable

codecov bot commented Oct 31, 2024 • edited Loading

Codecov Report

EdamAme-x commented Oct 31, 2024

yusukebe commented Oct 31, 2024

EdamAme-x commented Oct 31, 2024 •

edited

Loading

codecov bot commented Oct 31, 2024 •

edited

Loading