Skip to content

support uppercase hex characters in css color check #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
willkg opened this issue Oct 31, 2017 · 2 comments
Closed

support uppercase hex characters in css color check #354

willkg opened this issue Oct 31, 2017 · 2 comments
Milestone
1.0

Comments

@willkg
Copy link
Contributor

willkg commented Oct 31, 2017

This covers adding support for uppercase hex characters in the css color check regex.

From #287:

Adds uppercase check (A-F) in the css regex to pass css of the following format:
border-top: 2px #DA4534 solid;
@willkg willkg mentioned this issue Oct 31, 2017
Closed
@willkg willkg changed the title support upercase hex characters in css color check support uppercase hex characters in css color check Nov 29, 2017
@willkg willkg added this to the 1.0 milestone Nov 29, 2017
@willkg
Copy link
Contributor Author

willkg commented Nov 29, 2017

Tossing this in the 1.0 milestone. It might be easy to fix.

The CSS regex check is here:

html5lib-python/html5lib/filters/sanitizer.py

Line 838 in 32713a5

def sanitize_css(self, style):

@hugovk
Copy link
Contributor

hugovk commented Nov 30, 2017

I'll take this.

@hugovk hugovk mentioned this issue Nov 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@willkg @hugovk