Skip to content

Allows uppercase color codes in style #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

komaldembla
Copy link

Adds uppercase check (A-F) in the css regex to pass css of the following format:
border-top: 2px #DA4534 solid;

@codecov-io
Copy link

codecov-io commented Jul 22, 2016

Current coverage is 90.48% (diff: 100%)

Merging #287 into master will increase coverage by <.01%

@@             master       #287   diff @@
==========================================
  Files            50         50          
  Lines          6930       6934     +4   
  Methods           0          0          
  Messages          0          0          
  Branches       1336       1336          
==========================================
+ Hits           6270       6274     +4   
  Misses          500        500          
  Partials        160        160          

Powered by Codecov. Last update 14d4851...d43fa3b

@@ -1,4 +1,4 @@
Copyright (c) 2006-2013 James Graham and other contributors
Copyright (c) 2006-2013 James Graham, Google Inc. and other contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorship should just be left in AUTHORS.rst, otherwise the copyright notice would become silly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the file as suggested.

@willkg
Copy link
Contributor

willkg commented Sep 1, 2017

Sorry that no one has gotten to this, yet! This needs to be updated to reflect the sanitizer changes.

@komaldembla Can you update this PR? If not, I can look into it later.

@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg
Copy link
Contributor

willkg commented Oct 31, 2017

This is way out of date and the original author hasn't responded. Given that, I opened up issue #354 and I'm going to close this out.

@willkg willkg closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants