make compatible with python 3.6 #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors on invalid escape sequences in strings, such as "\s" i.e. anything not mentioned in https://docs.python.org/3/reference/lexical_analysis.html#strings
|
Oh, this isn't compatibility per-se, this is just avoiding DeprecationWarnings? (So it's essentially compatibility with some future version.) |
|
yes. Looking again I might have run into it with Still a good idea, though for a future python version. |
|
Oh, totally, still a good idea; thanks for the patch! |
|
(In case it was unclear: I didn't merge it earlier because I was still waiting on Travis CI to finish running against the merge with the Travis fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors on invalid escape sequences in strings, such as "\s"
i.e. anything not mentioned in https://docs.python.org/3/reference/lexical_analysis.html#strings