Skip to content

Google Code Issue 152: Doctypes don't match serialization output #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Google Code Issue 152: Doctypes don't match serialization output #36

wants to merge 1 commit into from

Conversation

gsnedders
Copy link
Member

Reported by @fantasai, Jun 1, 2010
What steps will reproduce the problem?
Serialize a document with an XHTML doctype as HTML or vice versa

What is the expected output? What do you see instead?
I expect an appropriate doctype. Or at least the ability to request an appropriate doctype.

I see instead the same doctype that was parsed in, even if it's not valid for the output.

My branch currently uses the attached changes.

@fantasai @gsnedders
Google Code Issue 152: Doctypes don't match serialization output
d207de7 
Change the Doctype as appropriate for the serialization format.
@gsnedders
Copy link
Member Author

I think this is better rewritten as a filter; there's no need for this to be in the main serializer.

@gsnedders
Copy link
Member Author

Something like gsnedders@0f902c4 is a far better approach, as it avoids touching the serializer itself.

@gsnedders gsnedders closed this May 7, 2013
@gsnedders gsnedders deleted the gcode-152 branch May 7, 2013 11:13
gsnedders pushed a commit to gsnedders/html5lib-python that referenced this pull request Nov 24, 2014
@Ms2ger
Merge pull request html5lib#36 from gsnedders/fix-3-script-data-doubl…
8a34f3c 
…e-escaped-dash-state

Fix html5lib#3: test ">" in script data double escaped dash state; r=jgraham
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsnedders @fantasai