Skip to content

Speed up CI #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2017
Merged

Speed up CI #385

merged 1 commit into from
Dec 4, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 4, 2017

It's usually quicker to have the slower build jobs run first, that way the build isn't waiting as at the end for one or two slow ones to cmoplete.

Taking numbers from a master build, rounding to nearest minutes, gives something like this in theory for five parallel jobs:

xxx
xx
xxxx
xxx
xxx
  xxx
   xxxx
   xxx
   xxx
    xxx
     xx
      xx
      xx
       xx
       xxx
       xxx
        xxx
        xxx
         xxxxxxx
          xxxxxxxxx
          xxxxxxxxx
1234567890123456789

In reality:

Slowest first, using same numbers:

xxxxxxx
xxxxxxxxx
xxxxxxxxx
xxx
xxx
   xxx
   xx
     xx
      xxx
       xxx
       xx
         xx
         xxxx
         xxx
         xxx
          xxx
           xxx
            xxx
            xxx
             xx
             xxxx
12345678901234567

This PR build:

@codecov-io
Copy link

codecov-io commented Dec 4, 2017 •
edited
Loading

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files          50       50           
  Lines        6950     6950           
  Branches     1328     1328           
=======================================
  Hits         6308     6308           
  Misses        483      483           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7708c4...0dcbd68. Read the comment docs.

@willkg
Copy link
Contributor

willkg commented Dec 4, 2017

I looked at the master builds for the last 10 rounds and the numbers are kind of all over the place and not consistent. So I'm not sure I see evidence that this will really improve the situation.

The specific change here is just reordering the environments which is benign, so I'm going to approve it and land it and we can see how future builds affect the hypothesis.

@willkg willkg merged commit 41bd598 into html5lib:master Dec 4, 2017
@hugovk hugovk deleted the speedup-ci branch December 4, 2017 13:57
@hugovk
Copy link
Contributor Author

hugovk commented Dec 4, 2017

For reference, here's the last 10 passing master builds (685-711), latest first:

Ran for 20 min 45 sec
Ran for 26 min 58 sec
Ran for 22 min 12 sec
Ran for 24 min 32 sec
Ran for 17 min 33 sec
Ran for 19 min 5 sec
Ran for 23 min 14 sec
Ran for 16 min 15 sec
Ran for 17 min 58 sec
Ran for 14 min 58 sec

@willkg willkg added this to the 1.0 milestone Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkg willkg willkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @codecov-io @willkg