Skip to content

Question/Issue about a test in tests18.dat #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
syjer opened this issue Mar 15, 2017 · 3 comments
Closed

Question/Issue about a test in tests18.dat #89

syjer opened this issue Mar 15, 2017 · 3 comments

Comments

@syjer
Copy link
Contributor

syjer commented Mar 15, 2017

Hi, recently, in tests18.dat the following test has been added in the commit (5fca014#diff-80f44ad8658d9cc87ce967f7514ebf8dR227):

#data
<!doctype html><template><plaintext>a</template>b
#errors
49: End of file seen and there were open elements.
36: Unclosed element “plaintext”.
25: Unclosed element “template”.
#document
| <!DOCTYPE html>
| <html>
|   <head>
|     <template>
|       <plaintext>
|         "a</template>b"
|   <body>

Maybe I'm mistaken, but the "content" string is missing for the template element? (like all the others tests with a template element and as described in the README ("Template contents are represented by the string "content" with the children below it."))

The expected result should be:

| <!DOCTYPE html>
| <html>
|   <head>
|     <template>
|       content
|         <plaintext>
|           "a</template>b"
|   <body>

instead?

Or am I missing something, and there is a specific reason that the "content" string is missing?

Thank you.
@gsnedders
Copy link
Member

@zcorpan this looks like a bug to me? (your test, from #87)

@zcorpan
Copy link
Contributor

zcorpan commented Mar 16, 2017 •
edited
Loading

Yep, I was not aware of the content string. parsetree doesn't emit that, either. @sideshowbarker ?

@syjer are you interested in fixing this?

@syjer
Copy link
Contributor Author

syjer commented Mar 16, 2017

@zcorpan sure, I'll provide a pull request asap :)

nox added a commit to nox/html5ever that referenced this issue Mar 16, 2017
@nox
Update html5lib-tests
72edf31 
html5lib/html5lib-tests#89
sideshowbarker added a commit to validator/validator that referenced this issue Mar 16, 2017
@sideshowbarker
Make /parsetree emit “content” for <template>
00bb376 
See html5lib/html5lib-tests#89 Thanks @syjer & @zcorpan
syjer added a commit to syjer/html5lib-tests that referenced this issue Mar 16, 2017
@syjer
fix html5lib#89, add missing 'content' string in template element
5951f58
@Ms2ger Ms2ger closed this as completed in c75a9f5 Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @zcorpan @syjer