-
Notifications
You must be signed in to change notification settings - Fork 342
TypeError: NetworkError when attempting to fetch resource. #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This change was meant to lower the usage of CORS proxies and improve loading time, so that HTML documents from https://raw.githubusercontent.com could be fetched directly. I didn't realize that HTMLPreview is used outside of GitHub/Bitbucket, like with Dropbox. I will make an exception for such cases. |
Ah, I understand. Yes, a friend of mine uses the page with dropbox (https://jdelcastilloshideout.blogspot.com/2020/09/paravicini-y-la-roca-rodante.html) and asked me why the page stopped working, so I investigated and found the issue. Thanks for the quick reply 😊. An exception is enough for my friend. |
When fetching a resource, try directly first. If it throws an error, then try with proxies. Fixes htmlpreview#95 Should also reduce drastically the petitions to the proxy servers (will only be made if the non-proxy fails)
Sorry for the reply, but perhaps you have disabled notifications of pull requests. You can check the result here: |
I also started encountering this error, but my file is on Github. Here's the file: https://github.com/openmm/pdbfixer/blob/master/Manual.html The following link produces the error message given above: https://htmlpreview.github.io/?https://github.com/openmm/pdbfixer/blob/master/Manual.html |
Is there anything I can do to work around this problem? |
@peastman The link you posted above (https://htmlpreview.github.io/?https://github.com/openmm/pdbfixer/blob/master/Manual.html) works fine for me. I checked the mentioned issue from your repo and the link is different. Simply update the link to this one and it will work again. |
When trying to fix the CORS error a few days ago, you made a change in the fetching code so now pages are fetched using fetch instead of fetchProxy.
adaa08a?branch=adaa08ac90758703e6294003b5a24a0e74286e17&diff=unified#diff-0f292e46fc1906eacb3fdbdaced082678d3b8d83fb44ab79b927d2abd836c358L107
Now, when using a page which has cors disabled, like dropbox, the service doesn't work.
http://htmlpreview.github.io/?https://www.dropbox.com/s/mgw65rktedx4pjl/Hello%20world.html?raw=1
Was that change a forgotten invalid fix? I recommend using fetchProxy again, so that dropbox links (and others) works again.
The text was updated successfully, but these errors were encountered: