-
Notifications
You must be signed in to change notification settings - Fork 749
Skip and page selection support in PagedIterator/PagedIterable #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Translating the requirement: it'd be convenient to allow |
I think the PageIterator simply needs to implement the "page" parameter to skip to a particular page. It support size but not page from what I can tell. |
…er for the main search. The alternative is to implement it at the page PagedIterable level which will require changes throughout all the classes that reference it. Since is primarily a search issue this solution might suffice.
@nodoze |
In #448, another scenario was mentioned - restarting a search from a specific page. One thing to keep in mind for searches is that the underlying data may have changed. At that point the page position of items may have changed. This a generally problem for any paged query though, so maybe that is something that we can leave to consumers of the API to figure out for themselves. |
I think it would make sense to add a |
See #1197 I'm thinking the following methods on the iterable: And adding methods to the iterator and page iterator: |
@bitwiseman Hey! Thank you for this library, works great! I ended up not using this library for integrating with the paginated GitHub APIs because of the lack of support for specific page number, and wrote my own simple client instead. I'd like to implement this, perhaps starting with these new methods in
Any updates to the design you thought of in the previous comments, about the new class Thanks, |
Please go ahead. |
Hey, could I have access to I have implemented two new classes We can have a discussion when I raise the PR for this, testing in progress. |
@anujhydrabadi |
This is some additional documentation in this area: |
Hello,
when listing users the GitHub Api provides a parameter since which allows you to specify an id of the user you've seen the last, when you start listing again (i.e after a crash) you skip the users you've seen. It'd great to have this parameter in the api i.e github.listUsers(sinceUserId). Do you think it would be feasible to add it there ?
Thank you
Jakub
The text was updated successfully, but these errors were encountered: